Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve detection of binary file encoding when editing executables. #1535

Merged
merged 1 commit into from
Apr 17, 2022
Merged

Improve detection of binary file encoding when editing executables. #1535

merged 1 commit into from
Apr 17, 2022
+5 −5

Conversation

meisterT
Copy link
Member

This now allows to have non-ASCII characters as ąśćżźć to not trigger
false positives.

Also show a nicer alert message while we are changing this code.

Part of #1526.

@meisterT
Improve detection of binary file encoding when editing executables.
404ca77 
This now allows to have non-ASCII characters as `ąśćżźć` to not trigger
false positives.

Also show a nicer alert message while we are changing this code.

Part of DOMjudge#1526.
@meisterT meisterT merged commit c32b995 into DOMjudge:main Apr 17, 2022
@baziorek baziorek mentioned this pull request Apr 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickygerritsen nickygerritsen nickygerritsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meisterT @nickygerritsen